fix: partition matrix by connected components in structural_singularity_removal!#124
Merged
Merged
Conversation
AayushSabharwal
force-pushed
the
as/fix-ensemble-bareiss
branch
from
b0575d7 to
7ae2908
Compare
…ity_removal!` Co-authored-by: Claude <noreply@anthropic.com>
AayushSabharwal
force-pushed
the
as/fix-ensemble-bareiss
branch
from
7ae2908 to
1587d3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the pivot selection algorithm is global and has a tiered preference, it will shuffle equations around a lot. If the model has disconnected components in
mm, this causes the components to eliminate differently compared to how they would behave in isolation. Partitioning the matrix avoids this, and reduces the cost of running this pass significantly for such systems. I'm considering a future PR to sort the equations before running Bareiss for improved reproducibility.