Skip to content

Fix double-negative error message in TransferFunction call #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baggepinnen merged 1 commit into from
May 16, 2026
Merged

Fix double-negative error message in TransferFunction call #1061

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ControlSystemsBase/src/freqresp.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ function (sys::TransferFunction)(s)
end

function (sys::TransferFunction)(z_or_omega::Number, map_to_unit_circle::Bool)
isdiscrete(sys) || throw(ArgumentError("It only makes no sense to call this function with discrete systems"))
isdiscrete(sys) || throw(ArgumentError("This function can only be called with discrete-time systems"))
if map_to_unit_circle
isreal(z_or_omega) ? evalfr(sys,exp(im*z_or_omega.*sys.Ts)) : error("To map to the unit circle, omega should be real")
else
Expand All @@ -304,7 +304,7 @@ function (sys::TransferFunction)(z_or_omega::Number, map_to_unit_circle::Bool)
end

function (sys::TransferFunction)(z_or_omegas::AbstractVector, map_to_unit_circle::Bool)
isdiscrete(sys) || throw(ArgumentError("It only makes no sense to call this function with discrete systems"))
isdiscrete(sys) || throw(ArgumentError("This function can only be called with discrete-time systems"))
vals = sys.(z_or_omegas, map_to_unit_circle)# evalfr.(sys,exp.(evalpoints))
# Reshape from vector of evalfr matrizes, to (in,out,freq) Array
nu,ny = size(vals[1])
Expand Down
Loading