Honor byte-order mark when parsing UTF-16 and UTF-8 input#65
Open
SAY-5 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62. UTF-16 (and UTF-8 BOM) documents crashed with a
BoundsErrorbecause the byte tokenizer was handed the raw bytes without any encoding detection, so the interleaved zero bytes desynced the</>scanning and walked off the end of the buffer.This adds a small normalization step at the single
Vector{UInt8}entry point: a leading BOM (FF FE,FE FF, orEF BB BF) is honored, UTF-16 is transcoded to UTF-8, and a UTF-8 BOM is stripped, so the tokenizer always sees UTF-8. Input without a BOM is returned unchanged. Added a regression test covering UTF-16 LE/BE and UTF-8 BOM round-trips.