Skip to content

Fix matrix-function primal type for Hermitian{<:Real} on Julia 1.12 #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CarloLucibello wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −4
Open

Fix matrix-function primal type for Hermitian{<:Real} on Julia 1.12 #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "ChainRules"
uuid = "082447d4-558c-5d27-93f4-14fc19e9eca2"
version = "1.73.0"
version = "1.73.1"

[deps]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Expand Down
14 changes: 13 additions & 1 deletion src/rulesets/LinearAlgebra/symmetric.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,19 @@ function _matfun(f, A::LinearAlgebra.RealHermSymComplexHerm)
df_dλ = last.(unthunk.(fλ_df_dλ))
fA = (U * Diagonal(fλ)) * U'
Y = if eltype(A) <: Real
Symmetric(fA)
if eltype(fλ) <: Complex
# a complex-valued function of a real Herm/Sym is always `Symmetric`
Symmetric(fA)
else
# Julia 1.12 made real-valued matrix functions of `Hermitian{<:Real}`
# return `Hermitian` (they previously returned `Symmetric`); match the
# type of the primal `f(A)`.
@static if VERSION >= v"1.12"
_symhermtype(A)(fA)
else
Symmetric(fA)
end
end
elseif eltype(fλ) <: Complex
fA
else
Expand Down
10 changes: 8 additions & 2 deletions test/rulesets/LinearAlgebra/symmetric.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,8 +328,11 @@
if is_inferable(f, A)
Y_ad, ∂Y_ad = @maybe_inferred frule((ZeroTangent(), ΔA), f, A)
else
# real-valued functions of `TA{<:Real}` return `TA` on Julia
# 1.12+ (they previously always returned `Symmetric`)
SR = @static VERSION >= v"1.12" ? TA{T} : Symmetric{T}
TY = T∂Y = if T <: Real
Union{Symmetric{Complex{T}},Symmetric{T}}
Union{Symmetric{Complex{T}},SR}
else
Union{Matrix{T},Hermitian{T}}
end
Expand Down Expand Up @@ -381,8 +384,11 @@
if is_inferable(f, A)
Y_ad, back = @maybe_inferred rrule(f, A)
else
# real-valued functions of `TA{<:Real}` return `TA` on Julia
# 1.12+ (they previously always returned `Symmetric`)
SR = @static VERSION >= v"1.12" ? TA{T} : Symmetric{T}
TY = if T <: Real
Union{Symmetric{Complex{T}},Symmetric{T}}
Union{Symmetric{Complex{T}},SR}
else
Union{Matrix{T},Hermitian{T}}
end
Expand Down
Loading