add ParameterScope variable metadata#367
Open
hexaeder wants to merge 6 commits into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
a557333 to
1c110f7
Compare
Contributor
Benchmark Resultshttps://github.com/JuliaDynamics/NetworkDynamics.jl/actions/runs/27037865378/artifacts/7446980663 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature, a settable
scopefor a parameter.This is just for tracking, and throwing warnings. The idea: mark
so it can be checkt that every parameter within a component (VertexModel or EdgeModel) named
somthing+Vbasehas the same number.Similarily, you can mark stuff as global
to auto check that all parameters with the magic name
Sbaseactually contain the same number.Open questions/tasks:
:device->:component(less confusion in PowerDynamics)This is part of the solution towards JuliaEnergy/PowerDynamics.jl#265