Skip to content

Improve dump-on-error helper.#791

Merged
maleadt merged 1 commit into
mainfrom
tb/dump
May 30, 2026
Merged

Improve dump-on-error helper.#791
maleadt merged 1 commit into
mainfrom
tb/dump

Conversation

@maleadt
Copy link
Copy Markdown
Member

@maleadt maleadt commented May 29, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 73.07692% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.74%. Comparing base (45c44ae) to head (1b23f2d).

Files with missing lines Patch % Lines
src/compiler/compilation.jl 73.07% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
+ Coverage   81.56%   81.74%   +0.18%     
==========================================
  Files          66       66              
  Lines        3141     3145       +4     
==========================================
+ Hits         2562     2571       +9     
+ Misses        579      574       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metal Benchmarks

Details
Benchmark suite Current: 1b23f2d Previous: 45c44ae Ratio
array/accumulate/Float32/1d 818958 ns 817208 ns 1.00
array/accumulate/Float32/dims=1 1000625 ns 1010458.5 ns 0.99
array/accumulate/Float32/dims=1L 10590625 ns 9987624.5 ns 1.06
array/accumulate/Float32/dims=2 1284437.5 ns 1291875 ns 0.99
array/accumulate/Float32/dims=2L 4893937.5 ns 6878666.5 ns 0.71
array/accumulate/Int64/1d 985708.5 ns 964709 ns 1.02
array/accumulate/Int64/dims=1 1118208.5 ns 1147833.5 ns 0.97
array/accumulate/Int64/dims=1L 12495708.5 ns 11752375 ns 1.06
array/accumulate/Int64/dims=2 1459229 ns 1464771 ns 1.00
array/accumulate/Int64/dims=2L 9111000 ns 9400083 ns 0.97
array/broadcast 337583 ns 383333 ns 0.88
array/construct 6042 ns 6250 ns 0.97
array/permutedims/2d 624708.5 ns 607041 ns 1.03
array/permutedims/3d 1131834 ns 1135104 ns 1.00
array/permutedims/4d 1369188 ns 1995750 ns 0.69
array/private/copy 368833 ns 413562.5 ns 0.89
array/private/copyto!/cpu_to_gpu 249354.5 ns 365167 ns 0.68
array/private/copyto!/gpu_to_cpu 280062.5 ns 367250 ns 0.76
array/private/copyto!/gpu_to_gpu 263937.5 ns 346167 ns 0.76
array/private/iteration/findall/bool 1131000 ns 1075417 ns 1.05
array/private/iteration/findall/int 1295542 ns 1254916 ns 1.03
array/private/iteration/findfirst/bool 1266250 ns 1361333 ns 0.93
array/private/iteration/findfirst/int 1318833 ns 1445250 ns 0.91
array/private/iteration/findmin/1d 1439250 ns 1470958 ns 0.98
array/private/iteration/findmin/2d 1181833 ns 1221166 ns 0.97
array/private/iteration/logical 1776145.5 ns 1642625 ns 1.08
array/private/iteration/scalar 1787854 ns 2733541 ns 0.65
array/random/rand/Float32 606416.5 ns 627708.5 ns 0.97
array/random/rand/Int64 658667 ns 674417 ns 0.98
array/random/rand!/Float32 512916 ns 585083 ns 0.88
array/random/rand!/Int64 482750 ns 508542 ns 0.95
array/random/randn/Float32 575833 ns 590708 ns 0.97
array/random/randn!/Float32 487416 ns 548667 ns 0.89
array/reductions/mapreduce/Float32/1d 501958 ns 770917 ns 0.65
array/reductions/mapreduce/Float32/dims=1 464291.5 ns 517583 ns 0.90
array/reductions/mapreduce/Float32/dims=1L 722375 ns 929916 ns 0.78
array/reductions/mapreduce/Float32/dims=2 466000 ns 513833 ns 0.91
array/reductions/mapreduce/Float32/dims=2L 1076250 ns 1364167 ns 0.79
array/reductions/mapreduce/Int64/1d 775896 ns 952042 ns 0.81
array/reductions/mapreduce/Int64/dims=1 771916.5 ns 800250 ns 0.96
array/reductions/mapreduce/Int64/dims=1L 1219792 ns 1572771 ns 0.78
array/reductions/mapreduce/Int64/dims=2 970708 ns 973459 ns 1.00
array/reductions/mapreduce/Int64/dims=2L 2264167 ns 2268062.5 ns 1.00
array/reductions/reduce/Float32/1d 499666 ns 510250 ns 0.98
array/reductions/reduce/Float32/dims=1 460708.5 ns 516167 ns 0.89
array/reductions/reduce/Float32/dims=1L 721354.5 ns 818125 ns 0.88
array/reductions/reduce/Float32/dims=2 465417 ns 512875 ns 0.91
array/reductions/reduce/Float32/dims=2L 1094208.5 ns 1355666.5 ns 0.81
array/reductions/reduce/Int64/1d 797083 ns 1004500 ns 0.79
array/reductions/reduce/Int64/dims=1 768083 ns 894041.5 ns 0.86
array/reductions/reduce/Int64/dims=1L 1249062.5 ns 1645604.5 ns 0.76
array/reductions/reduce/Int64/dims=2 957375 ns 1044542 ns 0.92
array/reductions/reduce/Int64/dims=2L 2265333 ns 2269083 ns 1.00
array/shared/copy 169083 ns 229625 ns 0.74
array/shared/copyto!/cpu_to_gpu 41792 ns 41250 ns 1.01
array/shared/copyto!/gpu_to_cpu 41417 ns 41833 ns 0.99
array/shared/copyto!/gpu_to_gpu 48166 ns 42375 ns 1.14
array/shared/iteration/findall/bool 1138708 ns 1078959 ns 1.06
array/shared/iteration/findall/int 1294958 ns 1254791 ns 1.03
array/shared/iteration/findfirst/bool 1040042 ns 1094000 ns 0.95
array/shared/iteration/findfirst/int 1077229 ns 1099916 ns 0.98
array/shared/iteration/findmin/1d 1210062.5 ns 1211791 ns 1.00
array/shared/iteration/findmin/2d 1185833.5 ns 1217500 ns 0.97
array/shared/iteration/logical 1633500 ns 1480750 ns 1.10
array/shared/iteration/scalar 9500 ns 9959 ns 0.95
integration/byval/reference 1179770.5 ns 1163375 ns 1.01
integration/byval/slices=1 1180958 ns 1170875 ns 1.01
integration/byval/slices=2 2128958 ns 2100083 ns 1.01
integration/byval/slices=3 20991625 ns 7772687.5 ns 2.70
integration/metaldevrt 463167 ns 492292 ns 0.94
kernel/indexing 327124.5 ns 373208 ns 0.88
kernel/indexing_checked 316750 ns 375750 ns 0.84
kernel/launch 15042 ns 15333 ns 0.98
kernel/rand 350125 ns 392167 ns 0.89
latency/import 1410243562.5 ns 1397378104.5 ns 1.01
latency/precompile 30082965667 ns 30031977437 ns 1.00
latency/ttfp 1682970708.5 ns 1661208125 ns 1.01
metal/synchronization/context 1145.8 ns 1137.5 ns 1.01
metal/synchronization/stream 781.25 ns 796.156862745098 ns 0.98

This comment was automatically generated by workflow using github-action-benchmark.

@maleadt maleadt merged commit 543e81b into main May 30, 2026
15 checks passed
@maleadt maleadt deleted the tb/dump branch May 30, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant