Add Rect4 type aliases and Extents.extent override for Rect4 (ZM)#279
Merged
Conversation
Adds `Rect4{T}` and concrete aliases (`Rect4d`, `Rect4f`, `Rect4i`) following
the existing `Rect2`/`Rect3` pattern, and implements `Extents.extent` for 4D
rectangles returning an Extent with X, Y, Z, M fields.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Covers the new Rect4 extent method and aliases, matching the existing Rect2/Rect3 test pattern in the Extent testset. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes / supersedes #218 on latest master.
Summary
Rect4{T}type alias (i.e.Rect{4,T}) and concrete aliasesRect4d,Rect4f,Rect4i, following the existingRect2/Rect3patternExtents.extent(rect::Rect4)returning anExtentwithX,Y,Z,Mfields (for XY + Z + measure coordinates)@docsymbol list to include the4-dim rowNote:
Extents.extentforRect3was already merged in a prior PR, so only theRect4pieces are new here.Test plan
Rect4(0.0, 0.0, 0.0, 0.0, 1.0, 1.0, 1.0, 1.0)constructs successfullyExtents.extent(::Rect4)returns correctExtent(X=…, Y=…, Z=…, M=…)Rect4d,Rect4f,Rect4iresolve to the correct concrete types🤖 Generated with Claude Code