Tune MatrixWorkspace LU and QR solve paths#712
Draft
saschatimme wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This updates
MatrixWorkspaceto keep its matrix and factor buffers as plainMatrix{ComplexF64}storage, then routes larger square/rectangular solves through stdlib/LAPACK paths where the benchmarks favor them.Changes:
StructArraystorage fromMatrixWorkspace;optimize_data_structureremains accepted as a no-opUpperTriangularfor the small custom LU/QR solve pathsn >= 28n >= 44n=27/28, QRn=43/44, plus a rectangular QR caseValidation
test/linear_algebra_test.jl: 54/54 passingTracker: 125/125 passingLinear Spaces: 45/45 passing0.984xorigin/mainat09484ceeversus this branch, single-threaded BLAS,BenchmarkTools.@belapsed, workload isMatrixWorkspacefullupdate! + ldiv!Benchmark Summary
n x nn=3:602n x nn=3:60Absolute speedup is
main_time_ns - branch_time_ns; relative speedup ismain_time_ns / branch_time_ns. Negative absolute speedups indicate branch was slower for that size.