refactor: move import merge strategy from UI to template-store#203
Open
JuliaKalder wants to merge 1 commit into
Open
refactor: move import merge strategy from UI to template-store#203JuliaKalder wants to merge 1 commit into
JuliaKalder wants to merge 1 commit into
Conversation
- Add exportable importTemplates(validTemplates, mode) to template-store.js
with append/skip/replace logic, returning { added, skipped, replaced }
- Slim executeImport in options.js to read the UI radio value, pre-process
templates (strip tracking fields, sanitize body), then delegate to importTemplates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
importTemplates(validTemplates, mode)intomodules/template-store.js— it iterates templates, compares by name (case-insensitive), applies the append/skip/replace merge mode, and returns{ added, skipped, replaced }executeImportinoptions/options.jsis now a thin UI wrapper: reads the radio value, strips tracking fields, sanitizes bodies (DOM-dependent step that stays in the UI layer), then callsawait importTemplates(sanitized, mode)and passes counts toshowImportFeedbackFixes #94