Avoid pirating qr by shadowing the function#497
Open
jishnub wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #497 +/- ##
==========================================
+ Coverage 90.00% 90.13% +0.13%
==========================================
Files 27 27
Lines 3742 3741 -1
==========================================
+ Hits 3368 3372 +4
+ Misses 374 369 -5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dlfivefifty
requested changes
Jan 6, 2026
| \(A::TransposeFact{<:Any,<:BandedLU}, B::Transpose{<:Any,<:AbstractVecOrMat}) = A \ copy(B) | ||
|
|
||
| _factorize(::AbstractBandedLayout, _, A) = size(A,1) == size(A,2) ? lu(A) : qr(A) | ||
| _factorize(::AbstractBandedLayout, _, A) = size(A,1) == size(A,2) ? lu(A) : LinearAlgebra.qr(A) |
Member
There was a problem hiding this comment.
Shouldn't this call BandedMatrices.qr?
Member
|
Don't we also need a |
Member
Author
|
Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a
BandedMatrices.qrthat is distinct fromLinearAlgebra.qr.