Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends the Map transform to accept types in addition to functions, enabling more convenient pipeline patterns with type constructors. The changes allow passing types directly to the transform, which will be called as constructors on the selected columns.
- Extended
Mapconstructor to accept types alongside functions as callable arguments - Updated type definitions to support
Union{Function,Type}instead of justFunction - Added comprehensive test coverage for the new type-based functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/transforms/map.jl | Core implementation adding type support through updated type aliases and extraction logic |
| test/transforms/map.jl | Test cases covering type constructors with and without target names |
| test/shows.jl | Updated display tests to reflect new Union{Function, Type} signature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 50 50
Lines 1440 1442 +2
=======================================
+ Hits 1416 1418 +2
Misses 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eliascarv
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow types in
Maptransform to enable convenient pipelines like