Add tests based on python's itertools#130
Open
natemcintosh wants to merge 9 commits intoJuliaMath:masterfrom
Open
Add tests based on python's itertools#130natemcintosh wants to merge 9 commits intoJuliaMath:masterfrom
natemcintosh wants to merge 9 commits intoJuliaMath:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #130 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 7 7
Lines 728 728
=======================================
Hits 706 706
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Looks like the failure on Julia 1.0 on windows is because PyCall failed to build. Not sure how to get around that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to ignore and close this PR without explanation.
The basic idea here is to test the Julia version against the python itertools.
Assumptions: python's
itertoolslibrary is correct.