Fix stirlings2 bug

[o314]

stirlings2 is implemented twice in this package.

• stirlings2 is correct but recursive and slow.
• nfixedsetpartitions is bugged eg. it silently overflows.

stirlings2 is slow :

julia> @btime stirlings2_new(25,7)
  17.546 μs (431 allocations: 7.09 KiB)
227832482998716310

julia> @btime stirlings2(25,7)
  594.258 μs (0 allocations: 0 bytes)
227832482998716310

nfixedsetpartitions is bugged :

@test_broken nfixedsetpartitions(21, 13) >= 0
@test_broken nfixedsetpartitions(21, 14) >= 0
@test_broken nfixedsetpartitions(21, 15) >= 0
@test_broken nfixedsetpartitions(21, 16) >= 0
@test_broken nfixedsetpartitions(21, 17) >= 0
@test_throws OverflowError nfixedsetpartitions(21,21)

SEE

• https://mathworld.wolfram.com/StirlingNumberoftheSecondKind.html
• https://dlmf.nist.gov/26.8

[codecov-io]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (9cd51fb) to head (d4d32d9).
Report is 46 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   95.79%   95.29%   -0.50%     
==========================================
  Files           8        8              
  Lines         642      638       -4     
==========================================
- Hits          615      608       -7     
- Misses         27       30       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mschauer]

Can you use standard formatting?

[mschauer]

There is also #126, let's compare those two.