Skip to content

Replace padded_similar by similar #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkitti merged 1 commit into from
Jun 5, 2026
Merged

Replace padded_similar by similar #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/b-splines/prefiltering.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@ padded_axes(axs, it::InterpolationType) = (ax->padded_axis(ax, it)).(axs)
padded_axes(axs::NTuple{N,AbstractUnitRange}, it::NTuple{N,InterpolationType}) where N =
padded_axis.(axs, it)

padded_similar(::Type{TC}, inds::Tuple{Vararg{Base.OneTo{Int}}}) where TC = Array{TC}(undef, length.(inds))
padded_similar(::Type{TC}, inds) where TC = OffsetArray{TC}(undef, inds)

# Narrow ax by the amount that axpad is larger
padinset(ax::AbstractUnitRange, axpad) = 2*first(ax)-first(axpad):2*last(ax)-last(axpad)
function padinset(ax::Base.OneTo, axpad::Base.OneTo)
Expand All @@ -20,7 +17,7 @@ copy_with_padding(A, it) = copy_with_padding(eltype(A), A, it)
function copy_with_padding(::Type{TC}, A, it::DimSpec{InterpolationType}) where {TC}
indsA = axes(A)
indspad = padded_axes(indsA, it)
coefs = padded_similar(TC, indspad)
coefs = similar(Array{TC}, indspad)

Copilot AI Oct 1, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The replacement similar(Array{TC}, indspad) may not be functionally equivalent to the original padded_similar(TC, indspad). The original function returned OffsetArray{TC}(undef, inds) for non-OneTo indices, but similar(Array{TC}, indspad) will always return a regular Array type regardless of the index type. This could break functionality when indspad contains offset indices.

Copilot uses AI. Check for mistakes.

@mkitti mkitti Oct 1, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that actually a problem based on how coefs is used?

@jishnub jishnub Oct 1, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Copilot isn't correct here. similar will return an OffsetArray if the package is loaded, so there's no difference here.

if indspad == indsA
coefs = copyto!(coefs, A)
else
Expand Down
Loading