Skip to content

Syntax fix: callable type instead of tuple assignment#647

Merged
Keno merged 1 commit into
JuliaMath:masterfrom
mlechu:fix-tuple-assign
Jun 11, 2026
Merged

Syntax fix: callable type instead of tuple assignment#647
Keno merged 1 commit into
JuliaMath:masterfrom
mlechu:fix-tuple-assign

Conversation

@mlechu

@mlechu mlechu commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Lowering has a bug where an assignment to a where-wrapped tuple is treated like an anonymous function, and it's a very easy typo to make when trying to add a method to a callable type. I found this syntax in two packages, and both seemed to be typos, so this PR corrects the syntax before I make it a proper error. Issue reference: JuliaLang/julia#62051

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.83%. Comparing base (390fd26) to head (f0076c1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #647      +/-   ##
==========================================
- Coverage   88.09%   87.83%   -0.26%     
==========================================
  Files          29       29              
  Lines        1906     1907       +1     
==========================================
- Hits         1679     1675       -4     
- Misses        227      232       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stevengj

Copy link
Copy Markdown
Member

CI failures on nightly seem unrelated (due to Zygote).

@Keno Keno merged commit 5b5a0f4 into JuliaMath:master Jun 11, 2026
11 of 16 checks passed
@IanButterworth

Copy link
Copy Markdown

Can we get a release? This will trip up pkgeval etc.

@mkitti

mkitti commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Ok. I will work on a release.

@mkitti

mkitti commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Released as v0.16.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants