Conversation
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
+ Coverage 44.60% 45.23% +0.62%
==========================================
Files 42 43 +1
Lines 1307 1322 +15
==========================================
+ Hits 583 598 +15
Misses 724 724
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cscherrer
left a comment
There was a problem hiding this comment.
Thanks @nignatiadis ! I pushed a commit running JuliaFormatter, and added a suggestion for rand. Unless there's an efficiency benefit to going through Distributions, this seems pretty clean to me. Let me know what you think :)
Co-authored-by: Chad Scherrer <chad.scherrer@gmail.com>
|
Thank you @cscherrer. Definitely makes sense to code it directly (and in fact, that's exactly the implementation in Distributions.jl). |
|
Is there anything using |
|
Just removed |
cscherrer
left a comment
There was a problem hiding this comment.
Looks good! Thanks again @nignatiadis
A short PR that implements the BetaBinomial distribution. This is needed for #226, but the PR should be self-contained.
I tried to follow the code for
Binomialbut am not sure about some things (especiallyrandhaving a separate signature withTuple{I,A}}) where {I<:Integer,A}).