Skip to content

Fix definition of Buffer methods in GPU pkgextensions #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giordano merged 1 commit into from
Apr 17, 2026
+5 −5
Merged

Fix definition of Buffer methods in GPU pkgextensions #947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "MPI"
uuid = "da04e1cc-30fd-572f-bb4f-1f8673147195"
authors = []
version = "0.20.25"
version = "0.20.26"

[deps]
Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"
Expand Down
4 changes: 2 additions & 2 deletions ext/AMDGPUExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module AMDGPUExt

using AMDGPU: AMDGPU
using MPI: MPIPtr, Buffer, Datatype
using MPI: MPI, MPIPtr, Buffer, Datatype

function Base.cconvert(::Type{MPIPtr}, A::AMDGPU.ROCArray{T}) where T
A
Expand All @@ -19,7 +19,7 @@ function Base.unsafe_convert(::Type{MPIPtr}, V::SubArray{T,N,P,I,true}) where {T
return reinterpret(MPIPtr, pV)
end

function Buffer(arr::AMDGPU.ROCArray)
function MPI.Buffer(arr::AMDGPU.ROCArray)
Buffer(arr, Cint(length(arr)), Datatype(eltype(arr)))
end

Expand Down
4 changes: 2 additions & 2 deletions ext/CUDAExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module CUDAExt

using CUDA: CUDA
using MPI: MPIPtr, Buffer, Datatype
using MPI: MPI, MPIPtr, Buffer, Datatype

function Base.cconvert(::Type{MPIPtr}, buf::CUDA.CuArray{T}) where T
Base.cconvert(CUDA.CuPtr{T}, buf) # returns DeviceBuffer
Expand All @@ -19,7 +19,7 @@ function Base.unsafe_convert(::Type{MPIPtr}, V::SubArray{T,N,P,I,true}) where {T
return reinterpret(MPIPtr, pV)
end

function Buffer(arr::CUDA.CuArray)
function MPI.Buffer(arr::CUDA.CuArray)
Buffer(arr, Cint(length(arr)), Datatype(eltype(arr)))
end

Expand Down
Loading