Handle escaped module names from Julia 1.12 hygienic macro expansion#36
Open
PatrickHaecker wants to merge 4 commits into
Open
Handle escaped module names from Julia 1.12 hygienic macro expansion#36PatrickHaecker wants to merge 4 commits into
PatrickHaecker wants to merge 4 commits into
Conversation
added 2 commits
April 6, 2026 06:59
Julia 1.12 wraps module names in Expr(:escape, :Name) during hygienic macro expansion. This caused explore_module! to fail because it expected a bare Symbol in the module name position. Use unescape() to unwrap the module name before recording it as an assignment, with a guard for non-Symbol results.
Member
|
Thanks for your PR! Would it be possible to write a more realistic test case? You could make a macro, and then let Julia macroexoand it and test the result. |
Replace the manually constructed `Expr(:module, true, Expr(:escape, :a), ...)`
test with a macro + macroexpand test mimicking `@enumx`, as suggested by fonsp.
On Julia 1.12, macros that use `esc()` with `:toplevel` produce
`Expr(:escape, :Name)` inside `Expr(Symbol("hygienic-scope"), ...)` after
`macroexpand`.
Author
|
Something like the most recent commit? If not, please feel free to suggest test code directly. For reference, I observed the original problem when using EnumX.jl in a (proprietary) notebook with Julia 1.12. |
Member
|
Thanks! Did you change from |
Author
|
Thanks, @fonsp. I hadn't really understood the I hope this is a step in the right direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia 1.12 wraps module names in
Expr(:escape, :Name)during hygienicmacro expansion. This caused
explore_module!to fail because it expecteda bare Symbol in the module name position.
Use
unescape()to unwrap the module name before recording it as anassignment, with a guard for non-Symbol results.
Also widen Aqua test compat to include v1 in the second commit. I can remove this change, if it is not welcomed.
This change was needed to make a notebook work with Julia 1.12 which worked previously without the change with Julia 1.11.
I used Claude Opus 4.6 to create the commit and fine-tuned it afterwards.