Add visible warning about subdirs#533
Open
gdalle wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 406 403 -3
=========================================
- Hits 406 403 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CompatHelper PR's, I have often had the case where
Project.tomltest/Project.tomlbecauseCompatHelper.main()does not includesubdirs = ["", "test", "docs"]This PR tries to correct course by making it more explicit that
subdirsis among the most important options to customize in a realistic package. It is important because CompatHelper itself doesn't have atest/Project.tomland so we cannot directly demonstrate that inside itsCompatHelper.ymlfile (although we could add docs).Related:
docs/Project.tomlandtest/Project.tomlas well #454