add commit hash information to registry#97
Open
simonbyrne wants to merge 5 commits into
Open
Conversation
9096e44 to
ed1d1f6
Compare
ed1d1f6 to
0ceb204
Compare
b7e68b7 to
9415286
Compare
simonbyrne
commented
Dec 31, 2023
Member
|
Instead of sticking everything at the same level as versions = Dict()
versions["1.2.3"] = Dict(
"git-tree-sha1" => "...",
"optional" => Dict(
"git-commit-sha1" => "...",
"some-other-info" => "helloworld",
),
) |
Contributor
Author
|
that seems more complicated? |
3f6a5b9 to
0329c2d
Compare
Contributor
Author
|
I decided against including |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First part of JuliaLang/Pkg.jl#3718.
This adds 3 optional keys to each version:
git-commit-sha1: the hash of a git commit object corresponding to the release. This is required if any of the other keys exist.git-tag-name: the name of the git tagsubdir: the subdirectory of the tree with respect to the root of the repository.These should satisfy the following:
subdirof the commitgit-commit-sha1should begit-tree-sha1. In other words,git rev-parse $(git-commit-sha1):$(subdir) == $(git-tree-sha1). Ifsubdiris not defined, then it should be the root tree.git-tag-nameshould resolve to the commitgit-commit-sha1. That is,git rev-parse $(git-tag-name)^{commit} == $(git-commit-sha1)Unlike
git-tree-sha1, these keys should all be considered potentially mutable (i.e. the repository may be modified so that the values of these keys may change).cc @IanButterworth