Skip to content

add NullRegularizer#156

Open
MaxenceGollier wants to merge 12 commits intoJuliaSmoothOptimizers:masterfrom
MaxenceGollier:null-regularizer
Open

add NullRegularizer#156
MaxenceGollier wants to merge 12 commits intoJuliaSmoothOptimizers:masterfrom
MaxenceGollier:null-regularizer

Conversation

@MaxenceGollier
Copy link
Collaborator

closes #155.

Copilot AI review requested due to automatic review settings March 2, 2026 15:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a NullRegularizer (identically-zero regularizer) so smooth problems can be run through solvers that expect a regularizer/prox interface.

Changes:

  • Introduces NullRegularizer implementation with prox!, shifted, and shift!.
  • Wires the new operator into the module via include("null.jl").
  • Adds tests covering evaluation and prox! behavior for Float64/Float32, including shifted/shift! calls.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/null.jl Implements the new null regularizer and its prox/shift-related methods.
src/ShiftedProximalOperators.jl Includes the new null.jl file in the module build.
test/runtests.jl Adds a new testset validating NullRegularizer behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 76.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.35%. Comparing base (753a97f) to head (6b45e45).
⚠️ Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
src/null.jl 66.66% 8 Missing ⚠️
src/shiftedNullBox.jl 85.71% 5 Missing ⚠️
src/ShiftedProximalOperators.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   73.71%   77.35%   +3.63%     
==========================================
  Files          22       26       +4     
  Lines         898     1029     +131     
==========================================
+ Hits          662      796     +134     
+ Misses        236      233       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a NullRegularizer

2 participants