add NullRegularizer#156
Open
MaxenceGollier wants to merge 12 commits intoJuliaSmoothOptimizers:masterfrom
Open
add NullRegularizer#156MaxenceGollier wants to merge 12 commits intoJuliaSmoothOptimizers:masterfrom
MaxenceGollier wants to merge 12 commits intoJuliaSmoothOptimizers:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a NullRegularizer (identically-zero regularizer) so smooth problems can be run through solvers that expect a regularizer/prox interface.
Changes:
- Introduces
NullRegularizerimplementation withprox!,shifted, andshift!. - Wires the new operator into the module via
include("null.jl"). - Adds tests covering evaluation and
prox!behavior forFloat64/Float32, includingshifted/shift!calls.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/null.jl |
Implements the new null regularizer and its prox/shift-related methods. |
src/ShiftedProximalOperators.jl |
Includes the new null.jl file in the module build. |
test/runtests.jl |
Adds a new testset validating NullRegularizer behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 73.71% 77.35% +3.63%
==========================================
Files 22 26 +4
Lines 898 1029 +131
==========================================
+ Hits 662 796 +134
+ Misses 236 233 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #155.