Skip to content

negbin now works with weights.#556

Merged
andreasnoack merged 1 commit intoJuliaStats:masterfrom
JockLawrie:negbinwts
May 8, 2024
Merged

negbin now works with weights.#556
andreasnoack merged 1 commit intoJuliaStats:masterfrom
JockLawrie:negbinwts

Conversation

@JockLawrie
Copy link
Copy Markdown
Contributor

negbin with weights is currently broken.
This branch fixes this, so that this works for example: negbin(F, D, args...; wts=wts).
A test case is included.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.04%. Comparing base (e2f6c98) to head (e079c8b).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #556      +/-   ##
==========================================
+ Coverage   89.86%   90.04%   +0.17%     
==========================================
  Files           8        8              
  Lines        1125     1125              
==========================================
+ Hits         1011     1013       +2     
+ Misses        114      112       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack andreasnoack merged commit 0f8418b into JuliaStats:master May 8, 2024
@nalimilan
Copy link
Copy Markdown
Member

This PR seems completely broken to me as it didn't pass wts to the second glm call inside the loop. The values in the test are the ones you get without any weights. I have a fix at #622.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants