Conversation
c1bd575 to
a4f4ddc
Compare
Codecov Report
@@ Coverage Diff @@
## master #419 +/- ##
==========================================
+ Coverage 94.31% 94.39% +0.07%
==========================================
Files 23 23
Lines 1637 1642 +5
==========================================
+ Hits 1544 1550 +6
+ Misses 93 92 -1
Continue to review full report at Codecov.
|
dmbates
left a comment
There was a problem hiding this comment.
Sorry not to review this previously. I just noticed now that you asked for my review.
At some point we should revisit the decision to use NaN for the value of sdest when there is no dispersion parameter. It seems that in modern Julia we should consider missing so we can extract a value of type T with coalesce(sdest(m), one(T)).
Thanks for straightening out the use of ϕ in loglikelihood.
…lday/glmmloglikelood
|
So we had actually revisited that decision in a previous PR (#418, on GLMM parametric bootstrap) -- I've now merged those changes back into this branch and am re-running the tests. |
Amongst other things, this makes it so that the
show(::GeneralizedLinearMixedModel)method works for models with a dispersion parameter.(
If it's not obvious from the commit history,this is me stripping off part of #291 so that at least some of those improvements make it in sooner rather than later.)