Skip to content

fix CategoricalArrays #330 #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PharmCat wants to merge 1 commit into from
Closed

fix CategoricalArrays #330 #337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/contrasts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ mutable struct FullDummyCoding <: AbstractContrasts
end

ContrastsMatrix(C::FullDummyCoding, levels::AbstractVector{T}) where {T} =
ContrastsMatrix(Matrix(1.0I, length(levels), length(levels)), levels, levels, C)
ContrastsMatrix(Matrix(1.0I, length(levels), length(levels)), Vector(levels), Vector(levels), C)
Copy link
Copy Markdown
Member

@palday palday Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ContrastsMatrix(Matrix(1.0I, length(levels), length(levels)), Vector(levels), Vector(levels), C)
ContrastsMatrix(Matrix(1.0I, length(levels), length(levels)), collect(levels), collect(levels), C)

Copy link
Copy Markdown
Author

@PharmCat PharmCat Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems collect doesn't work with Categorical 1.0


"Promote contrasts matrix to full rank version"
Base.convert(::Type{ContrastsMatrix{FullDummyCoding}}, C::ContrastsMatrix) =
Expand Down
Loading