Skip to content

ContrastsMatrix constructor accepts AbstractVector (including CategoricalArray) #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kleinschmidt merged 1 commit into from
Jan 22, 2026
Merged

ContrastsMatrix constructor accepts AbstractVector (including CategoricalArray) #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "StatsModels"
uuid = "3eaba693-59b7-5ba5-a881-562e759f1c8d"
version = "0.7.8"
version = "0.7.9"

[deps]
DataAPI = "9a962f9c-6df0-11e9-0e5d-c546b8b5ee8a"
Expand Down
6 changes: 3 additions & 3 deletions src/contrasts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,12 @@ struct ContrastsMatrix{C <: AbstractContrasts, M <: AbstractMatrix, T, U}
contrasts::C
invindex::Dict{T,Int}
function ContrastsMatrix(matrix::M,
coefnames::Vector{U},
levels::Vector{T},
coefnames::AbstractVector{U},
levels::AbstractVector{T},
contrasts::C) where {U, T, C <: AbstractContrasts, M <: AbstractMatrix}
allunique(levels) || throw(ArgumentError("levels must be all unique, got $(levels)"))
invindex = Dict{T,Int}(x=>i for (i,x) in enumerate(levels))
new{C,M,T,U}(matrix, coefnames, levels, contrasts, invindex)
new{C,M,T,U}(matrix, convert(Vector{U}, coefnames), convert(Vector{T}, levels), contrasts, invindex)
end
end

Expand Down
14 changes: 14 additions & 0 deletions test/contrasts.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,4 +418,18 @@
@test issetequal(cm.levels, [true, false])
end


@testset "FullDummy and AbstractVector (#337)" begin
cm = ContrastsMatrix(StatsModels.FullDummyCoding(), categorical([1, 2, 3]))
@test cm.levels == cm.coefnames == categorical([1, 2, 3])
@test cm.levels isa Vector{<:CategoricalValue}
@test cm.coefnames isa Vector{<:CategoricalValue}
@test cm.matrix == I(3)

cm = ContrastsMatrix(StatsModels.FullDummyCoding(), view([1 2 3], 1, 1:3))
@test cm.levels == cm.coefnames == [1, 2, 3]
@test cm.levels isa Vector{Int}
@test cm.coefnames isa Vector{Int}
@test cm.matrix == I(3)
end
end
Loading