Skip to content

Make Aqua.test_piracy recursive#377

Open
giordano wants to merge 4 commits into
JuliaTesting:masterfrom
giordano:mg/recursive-piracy
Open

Make Aqua.test_piracy recursive#377
giordano wants to merge 4 commits into
JuliaTesting:masterfrom
giordano:mg/recursive-piracy

Conversation

@giordano

@giordano giordano commented May 18, 2026

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented May 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.50%. Comparing base (3f18a8d) to head (bb5ae5c).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   87.45%   87.50%   +0.04%     
==========================================
  Files          12       12              
  Lines         526      528       +2     
==========================================
+ Hits          460      462       +2     
  Misses         66       66              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lgoettgens lgoettgens added bug Something isn't working test: piracy BREAKING labels Jun 5, 2026
@lgoettgens

Copy link
Copy Markdown
Collaborator

Thanks for your PR! Two comments:

  1. it unfortunately has conflicts
  2. Aqua already has a function walkmodules that could be used here, as it is quite similar. See
    walkmodules(m) do x
    for how it has been used in a different test that needs to recurse submodules

@giordano

Copy link
Copy Markdown
Contributor Author

I rebased on master, and used the existing walkmodules, but I removed the recursive argument I initially added to test_piracies because walkmodules makes a lot more annoying to support both a recursive a non-recursive version, and honestly I don't care too much about a non-recursive version (that's a footgun in my opinion)

@giordano

Copy link
Copy Markdown
Contributor Author

Bump

@lgoettgens lgoettgens self-requested a review June 19, 2026 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BREAKING bug Something isn't working test: piracy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

piracies detection only checks top module

2 participants