fix(ewan-ace): standardize snip naming to match cross-JVD conventions#118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's New
Renames and splits 6 EWAN Advanced Core & Edge service/interface snips to align with the naming conventions established in MaaS and MEBS libraries.
evpn-vpws-simple→evpn-vpws-vlan-based(matches MaaS precedent)evpn-elan-bridged/evpn-elan-simple→evpn-elan-vlan-based-irb/evpn-elan-vlan-basedevpn-vpws-fxc→evpn-fxc-vlan-aware(distinct EVPN family, not VPWS sub-type)mac-vrf-elansplit intoevpn-elan-vlan-bundle+evpn-elan-vlan-based-irb(EVO)ccc-vpws-muxsplit intovlan-ccc-esi+vlan-bridge(distinct encapsulations)Why
Cross-JVD dependency and compatibility graphs rely on consistent naming families (
service.evpn-elan,interface.ccc, etc.) to validate edges. The original EWAN ACE names used ad-hoc conventions that didn't match the regex families in the compatibility graph, making cross-JVD validation less reliable.Details
Testing