[#754] Contracts: Add canonical error namespace for all revert and panic conditions#878
Merged
Conversation
Introduce contracts/vault/src/errors.rs as the single VaultError source, replace user-facing panics with structured reverts in lib.rs, update tests and ERROR_CODE_CATALOG.md. Closes Junirezz#754.
esthertitilayo-dev
force-pushed
the
fix/754-contracts-add-canonical-error-namespace-for-all-revert-and-panic-conditions
branch
from
97e9a33 to
d6c3932
Compare
|
@esthertitilayo-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
esthertitilayo-dev
force-pushed
the
fix/754-contracts-add-canonical-error-namespace-for-all-revert-and-panic-conditions
branch
from
cd9a498 to
210e5d0
Compare
…ace-for-all-revert-and-panic-conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contracts/vault/src/errors.rsas the canonicalVaultErrornamespace (stable codes 1–49)panic!paths inlib.rswithResult<_, VaultError>revertstry_*+ expected error codes; expanddocs/api/ERROR_CODE_CATALOG.mdCloses #754
Test plan
cargo test -p vaultpasses in CIcargo build -p vault --target wasm32-unknown-unknown) succeedserrors.rsenum variants