Durable manual corrections and remediation groundwork#27
Draft
JunjoSick wants to merge 5 commits into
Draft
Conversation
…ion groundwork Continues the project-remediation plan (see docs/codex-handoff-project-remediation-2026-07-10.md): - Release/docs truth: 2.4.0-dev across workspace, CHANGELOG v2.3.0 + Unreleased, CONTRIBUTING CI commands - Windows CI job, cfg(unix) PDF tests, dependabot, RustSec + CodeQL workflows (not yet run on GitHub) - Migration 0007: translations origin/human_corrected/corrected_at; save_manual_correction freezes segments, excluded from cross-job cache - New `bookforge correct` CLI command; CSRF-protected dashboard save/flag/retry endpoints with durable segment_flags - Retry guidance persisted, survives resume, rendered into single + batch prompts; batch templates bumped v2->v3 with new PromptVersion::BatchV3 cache tag - Correction atomicity: staged rebuild -> validate -> DB persist -> atomic rename, with recovery path on rename failure - QA report gains corrected_segments and regenerates after corrections - AppState carries store_path (removes per-request cwd resolution) - request_segment_retry now rejects running/paused jobs - Tests: store flag/retry/guidance, CSRF + isolated-store e2e dashboard, retry-guidance lifecycle (548 workspace tests green) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The v2 dashboard could show review findings but non-developer users could not correct them safely. Main also lacked an unambiguous post-v2.3 identity, Windows test coverage, and dependency/security automation.
User impact
Users can now flag, edit, save, audit, and rebuild corrected translations from the dashboard or
bookforge correct. Manual edits are never overwritten by resume/QA/double-check and are never reused across jobs. Guided retries remain explicit and require stopping an active job first.Validation
cargo check --workspace --all-targets --lockedwith-D warningson Windows gnullvmcargo test --workspace --locked: 548 passedcargo fmt --all --checkgit diff --checkFollow-up in this branch
The remaining remediation plan is tracked in
docs/codex-handoff-project-remediation-2026-07-10.md: manual dashboard exercise, remote CI/security feedback, local clippy/MSRV, true live reconfiguration, modularization, and final release gates.