Skip to content

Dockerize -- WIP#1

Open
nimish wants to merge 13 commits intoJunweiLiang:masterfrom
nimish:dockerize
Open

Dockerize -- WIP#1
nimish wants to merge 13 commits intoJunweiLiang:masterfrom
nimish:dockerize

Conversation

@nimish
Copy link
Copy Markdown

@nimish nimish commented Jun 22, 2019

Dockerizes the whole stack so it can be run simply. Updates Yii to 1.1.20 for PHP 7 support.
TBD:

  • Update README to use new docker commands
  • Fixup asset paths inside DB
  • Set up CI runners with docker makefiles
  • Set up docker registry to push images

@nimish
Copy link
Copy Markdown
Author

nimish commented Jun 22, 2019

@JunweiLiang worth you taking a look here -- this will hopefully lay the support to make quicker changes.

@JunweiLiang JunweiLiang self-assigned this Jun 22, 2019
@JunweiLiang
Copy link
Copy Markdown
Owner

Thanks! I will take a look & test it by the end of next week.

@nimish
Copy link
Copy Markdown
Author

nimish commented Jun 22, 2019

So -- still work to be done here but I can hop on a video call whenever you're free to walk through it.

@nimish
Copy link
Copy Markdown
Author

nimish commented Jun 30, 2019

@JunweiLiang any blockers here? Was in hospital this week so not a lot moved, but would like to build off this.

@JunweiLiang
Copy link
Copy Markdown
Owner

Sorry, been busy with intern stuff. Give me three days so I could make sure the Yii and python updates don't break anything. Also, could you put the docker stuff into a folder? Thanks!

@nimish
Copy link
Copy Markdown
Author

nimish commented Jul 1, 2019

No problem -- will do.

@nimish
Copy link
Copy Markdown
Author

nimish commented Jul 3, 2019

Moved everything but the docker-compose.yaml (which really should live in the root) to docker dir. Working on a Makefile to create images.

Copy link
Copy Markdown
Owner

@JunweiLiang JunweiLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

@nimish
Copy link
Copy Markdown
Author

nimish commented Jul 6, 2019

Awesome. @JunweiLiang looks like there's a merge conflict in the d/l setup script -- I combined the chmod inside it to save a step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants