Fix the transparent theme so &theme=transparent actually renders transparent#26
Open
eudanielhenrique wants to merge 1 commit into
Open
Fix the transparent theme so &theme=transparent actually renders transparent#26eudanielhenrique wants to merge 1 commit into
eudanielhenrique wants to merge 1 commit into
Conversation
…ers transparent Closes Jurredr#14. The theme already existed but was broken: background was 'ffffff00' without the leading '#', and title/subtitle were missing '#' too, so none of them were valid SVG paint values. Fixed the hex values and changed the background to 'none' (rather than an alpha-channel hex) since that's universally supported by SVG renderers, unlike 8-digit #RRGGBBAA which depends on the renderer.
|
@eudanielhenrique is attempting to deploy a commit to the Jurre's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14.
The
transparenttheme already existed inthemes.tsbut was broken:backgroundwas'ffffff00'without the leading#, andtitle/subtitlewere missing#too, so none of them were valid SVG paint values (they'd fall back to default/invalid rendering rather than being transparent).Fixed the hex values, and changed
backgroundto'none'rather than an alpha-channel hex, sincefill="none"is universally supported by SVG renderers — an 8-digit#RRGGBBAAalpha hex depends on renderer support that isn't guaranteed everywhere this gets embedded (e.g. some Markdown/image proxies).Documented
&theme=transparentin the README.Test plan
npm run buildcompiles cleanlyfill="none"for the card background