IconPicker: Bugfix - no longer show "pointer" when disabled.#10
Merged
Conversation
This is because of the following css in `.icon-preview`:
```
&[for] {
cursor: pointer;
}
```
Fixes #9
kostia
reviewed
Jan 12, 2026
Contributor
kostia
left a comment
kostia
left a comment
There was a problem hiding this comment.
Code looks good, but how can I try this out manually? Or should I only check the code, not the actual behavior?
Contributor
Author
|
With #11 and this PR you should be able to start the portal app, change an icon in an icon widget and change to diff mode. Now the changes icon is shown and hover no pointer cursor is shown. |
Contributor
Contributor
|
Somehow Github does not let me re-review this PR anymore 😢 Thus, APPROVED! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is because of the following css in
.icon-preview:Fixes #9