Talbot support setProjectLocation endpoint by adding appropriate tests#87
Closed
HMS-Victory wants to merge 3 commits into0.1.0from
Closed
Talbot support setProjectLocation endpoint by adding appropriate tests#87HMS-Victory wants to merge 3 commits into0.1.0from
HMS-Victory wants to merge 3 commits into0.1.0from
Conversation
Jonathan-Zollinger
requested changes
Mar 11, 2026
Member
Jonathan-Zollinger
left a comment
Jonathan-Zollinger
left a comment
There was a problem hiding this comment.
See changes requested below
| .setMissionId("2011050") | ||
| .setPostal("85281") | ||
| .setStakeId("504297") | ||
| .setState("Arizona") |
Member
There was a problem hiding this comment.
Since we're rolling this out across several hundred projects, let's replace this hard-coded address with a 30 real locations. let's add those in a json file for now in the resources directory. Let's ensure the sample includes the US and Canada for now, and that it varies whether it includes optional fields like AreaId or StakeId.
|
|
||
| when: | ||
| client.createProject(args) | ||
|
|
Member
There was a problem hiding this comment.
don't modify code outside of your scope of work - refactoring whitespace like this adds noise to commits
Jonathan-Zollinger
deleted the
Talbot-Support-setProjectLocation-endpoint
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a setupSpec to make important project data related to the specific project being edited available for all following tests. And added baseline tests for the setProjectLocation endpoint. #76