tests: remove 12 stray test binaries from dev — every PR's CI dies at test_e8_kernel (EACCES)#500
Merged
Conversation
…ct resolution make saw them as up-to-date targets in a fresh checkout (mode 100644, no exec bit) and skipped the build, so every CI run against dev now dies at test_e8_kernel with EACCES. The .gitignore listed test binaries one by one and had fallen behind; replaced with a pattern that ignores the build outputs and keeps the sources.
This was referenced Jul 21, 2026
Owner
|
Merged — thank you, and sorry: those binaries came in through merges I made (test_e8_kernel arrived with #465), and I fixed the same class of problem for #421 without generalising it. Your pattern-based ignore is the right fix precisely because it can't be forgotten next time. This was blocking every open PR's CI, so it goes in ahead of the release. |
JustVugg
added a commit
that referenced
this pull request
Jul 21, 2026
…ntainer (#452 step 4) Completes the E8/IQ3 arc: the converter can now produce a fmt=6 container and the engine loads it (after #465's decode kernel and #458's index codec). The CI failures on this PR were the stray-test-binary breakage fixed by #500, not this change — verified locally on post-#500 dev: clean merge, no binaries reintroduced, clean build, token-exact unchanged (fp 32/32, int4 21/32), full make check OK. Thanks @ZacharyZcR.
JustVugg
added a commit
that referenced
this pull request
Jul 21, 2026
…431 PR-C0) First step of the #431 plan: expert-group results stay on device instead of round-tripping to host, the dataflow a graph-captured decode needs. Validation provided as asked: sha256-identical completions with RESID=0 vs RESID=1 (6x RTX 5090, CUDA 13.3, GLM-5.2 int4, 256-token greedy, flag-only A/B on the same binary), perf at parity (6.04 vs 6.08 tok/s) — honestly presented as a structural change, not a speed claim. Rebased through the AMD/HIP single-source refactor. The red CI was the stray-test-binary breakage fixed by #500; verified locally on post-#500 dev: clean merge, clean build, token-exact unchanged, full make check OK. Thanks @ZacharyZcR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#368's conflict-resolution merge (cc7461f) accidentally committed 12 built test binaries under
c/tests/. They land in every fresh checkout as mode-100644 files (no exec bit), make sees an up-to-date target and skips compiling them, andrun_tests.pythen dies withPermissionError: [Errno 13] ... 'tests/test_e8_kernel'— currently failing the Engine/linux/macos jobs on every PR that merges with dev (see #434's latest run for an example).make check).gitignore— which had fallen behind the test suite, which is how these slipped in — with a pattern that ignores the built outputs and keeps the.c/.cu/.mm/.pysources