feat: add deep model preflight to coli doctor - #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coli doctor --deepmodel-container preflightmodel.safetensors.index.jsonCOLI_MODEL_MIRRORwith the same file-size and raw-header admission used by the runtime while preserving partial mirrorscoli doctorbehavior fast and add an additivemodefield to the versioned JSON reportThis complements the runtime missing-tensor diagnostics merged in #614 by moving broader container and mirror validation ahead of engine startup. Thank you @ZacharyZcR for #614; its diagnostics helped make the preflight boundary clear.
The deep path is bounded to 512 shards and 512 MiB per safetensors header or model index. Shard-sequence accounting remains constant-memory even for malformed numeric suffixes. It does not hash tensor payloads, load the model, start the engine, or initialize an accelerator.
Validation
A read-only field run against a real converted GLM-5.2 model and partial mirror reported:
out-00000throughout-00140contiguous; tail completeness left undeclaredCompatibility
--deepis opt-inmodefield and new check IDs