Skip to content

t#12

Merged
Jvr2022 merged 3 commits into
ci/github-split-backend-buildsfrom
main
Apr 8, 2026
Merged

t#12
Jvr2022 merged 3 commits into
ci/github-split-backend-buildsfrom
main

Conversation

@Jvr2022
Copy link
Copy Markdown
Owner

@Jvr2022 Jvr2022 commented Apr 8, 2026

Summary

What Changed

Verification

Copilot AI review requested due to automatic review settings April 8, 2026 17:18
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@Jvr2022 Jvr2022 merged commit 5815bb5 into ci/github-split-backend-builds Apr 8, 2026
3 of 4 checks passed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 8, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e74f0a4c-25bd-4564-ae04-2462450f3447

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines browser-engine build configuration and build reproducibility for the Linux Qt port by improving qmake engine selection logic and making local builds automatically reset when qmake arguments change.

Changes:

  • Removed the (now-unneeded) BrowserWindow::configureFallbackView(...) implementation and declaration.
  • Reworked seb-linux-qt.pro browser engine detection to support explicit forcing of Qt WebEngine vs WebKitGTK and to consistently emit SEB_HAS_* defines.
  • Updated scripts/build.sh to detect changed qmake arguments and run a clean when they differ; added a .gitignore entry for a local docs plan file.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/browser_window.h Removes the configureFallbackView private method declaration.
src/browser_window.cpp Removes the configureFallbackView implementation.
seb-linux-qt.pro Adds mutually-exclusive force flags and more structured engine detection/define emission.
scripts/build.sh Adds qmake-args fingerprinting and conditional distclean when args change.
.gitignore Ignores docs/next-update-plan.md (and keeps .codex ignored).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants