t#12
Conversation
build(qmake): support forced browser backend selection
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR streamlines browser-engine build configuration and build reproducibility for the Linux Qt port by improving qmake engine selection logic and making local builds automatically reset when qmake arguments change.
Changes:
- Removed the (now-unneeded)
BrowserWindow::configureFallbackView(...)implementation and declaration. - Reworked
seb-linux-qt.probrowser engine detection to support explicit forcing of Qt WebEngine vs WebKitGTK and to consistently emitSEB_HAS_*defines. - Updated
scripts/build.shto detect changed qmake arguments and run a clean when they differ; added a.gitignoreentry for a local docs plan file.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/browser_window.h | Removes the configureFallbackView private method declaration. |
| src/browser_window.cpp | Removes the configureFallbackView implementation. |
| seb-linux-qt.pro | Adds mutually-exclusive force flags and more structured engine detection/define emission. |
| scripts/build.sh | Adds qmake-args fingerprinting and conditional distclean when args change. |
| .gitignore | Ignores docs/next-update-plan.md (and keeps .codex ignored). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
What Changed
Verification