AppImage builds + fix false-positive in the anti-cheat + fix opening encrypted files. by tectrixdev · Pull Request #19 · Jvr2022/seb-linux

tectrixdev · 2026-04-27T20:55:19Z

Summary

Add support for building AppImages to truly be able to use seb-linux everywhere.
This fixes Unsupported device fedora #16.

What Changed

Patched workflow file and GitHub action to include AppImage building.
Fixed README.md formatting.
Changed README.md according to the changes.

Draft

Currently "it works on my machine" (debian container), but the GTK appimage build fails. That's why it's currently a draft. I'm actively working on fixing this and will report the status here.

Summary by CodeRabbit

New Features
- AppImage distribution added: Qt and WebKitGTK variants; AppImages are the primary Linux artifacts and include bundled dependencies.
Bug Fixes
- Debugger/process detection adjusted.
- Encrypted SEB format version updated; previously valid encrypted SEB payloads may be rejected.
Documentation
- README rewritten: AppImage vs binary guidance, build/install examples use AppImage, IMPORTANT note that encrypted sebs:// files can’t be opened yet, RISC-V/ARM AppImages not available.
Chores
- CI and build workflows updated to produce and publish AppImage artifacts only.

(For example, plasma panel colorizer needs gdbus running for some reason).

builds.

coderabbitai · 2026-04-27T20:55:27Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Switches packaging from Debian/tarball to AppImage artifacts across CI and release scripts; build scripts now use linuxdeploy to produce Qt and WebKitGTK AppImages; README updated for AppImage usage; gdb removed from prohibited process list; rncryptor format version bumped from 0x2 to 0x3.

Changes

Cohort / File(s)	Summary
Release Workflow `.github/workflows/release.yml`	Removed in-job apt install of many dev packages; upload & release steps now publish only `dist/*.AppImage` (removed `.deb`/`.tar.gz`).
Build Packaging Scripts `scripts/build-release.sh`, `scripts/build.sh`	Replaced deb/tar packaging with linuxdeploy-based AppImage creation in `build-release.sh`; both Qt and WebKitGTK AppImages produced and moved to `dist/`. `build.sh` and `build-release.sh` now optionally install apt deps when `apt` is available.
Documentation `README.md`	Rewrote build/run guidance for AppImage distribution, added notes about encrypted `sebs://` not supported, RISC‑V/ARM AppImages unavailable, and updated run/build examples to use AppImage names.
Security `src/security/security_service.cpp`	Removed `gdb` from hardcoded prohibited process list; minor whitespace/formatting cleanup in `detectProhibitedProcesses()`.
Encryption/Settings `src/settings/password_container.cpp`	Bumped rncryptor version constant `kSebRncryptorVersion` from `0x2` to `0x3`; decrypt logic now rejects `0x2` payloads as unsupported.
Misc / CI Artifacts `dist/*.AppImage` (new artifacts)	CI and build scripts now produce and upload AppImage artifacts (`-qt-x86_64.AppImage`, `-gtk-x86_64.AppImage`).

Sequence Diagram(s)

sequenceDiagram
  participant CI as CI workflow
  participant Builder as build script (scripts/build-release.sh)
  participant LinuxDeploy as linuxdeploy + plugins
  participant Artifacts as dist/*.AppImage
  participant GitHub as GitHub Release

  CI->>Builder: invoke build-release (Qt build)
  Builder->>LinuxDeploy: assemble AppDir, run linuxdeploy --plugin qt
  LinuxDeploy->>Artifacts: emit package-qt-x86_64.AppImage
  CI->>Builder: invoke build-release (WebKitGTK build)
  Builder->>LinuxDeploy: assemble AppDir, run linuxdeploy (webkit build)
  LinuxDeploy->>Artifacts: emit package-gtk-x86_64.AppImage
  CI->>GitHub: upload `dist/*.AppImage` and create Release

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Anticheat #5 — Modifies packaging logic in scripts/build-release.sh; directly related to switching packaging approach.

Suggested labels

codex

Suggested reviewers

Jvr2022

Poem

🐇
I hop in build-tools, fetching linuxdeploy bright,
Qt and WebKit bundled, two AppImages tonight,
gdb slipped from my watchful list, rncryptor changed its code,
CI packs the carrots, uploads down the road,
Hooray — the rabbit's release is light! 🥕✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description follows the template structure with Summary, What Changed, and additional context. It clearly states the linked issue (`#16`) and objectives, though includes draft status notes.
Linked Issues check	✅ Passed	The PR addresses issue `#16` (Fedora compatibility) by implementing AppImage distribution to enable broader distro support. The changes align with providing prebuilt, self-contained artifacts.
Out of Scope Changes check	✅ Passed	All changes are directly related to AppImage builds, CI/CD workflow updates, build scripts, and security/password handling for encrypted file formats. The modifications to security_service.cpp and password_container.cpp directly support the encrypted file handling mentioned in the PR title.
Title check	✅ Passed	The title addresses three main aspects of the changeset: AppImage builds (primary focus across multiple files), a fix for false-positives in anti-cheat (removing gdb from prohibited processes), and encrypted file handling (version bump for encrypted format). The title accurately reflects the core changes.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

tectrixdev · 2026-04-27T20:56:40Z

Currently having issues with GTK building.

tectrixdev · 2026-04-27T20:56:57Z

Qt build works fine BTW.

tectrixdev · 2026-04-27T21:05:29Z

I'm going to temporarily disable gtk builds to see if all else works.

tectrixdev · 2026-04-27T21:17:52Z

Working without debian and webkit build. Only the artifacts are out of order, I don't really know how to change that.

tectrixdev · 2026-04-27T21:18:30Z

As for the debian build, that's not my field of expertise, I'd suggest you take a look at it. Same for the webkit build, if you could figure out why it is giving me an error, that'd be great!

tectrixdev · 2026-04-27T21:18:42Z

I'm going to look at it again tomorrow.

Copilot

Pull request overview

This PR adds AppImage packaging to the release pipeline so SEB Linux can be distributed as a more portable, “runs anywhere” artifact (helping address Fedora/unsupported-device reports like #16), and it also adjusts the prohibited-process detection to avoid a false positive.

Changes:

Update release build script to produce an AppImage artifact (QtWebEngine path) and publish it via the release workflow.
Remove a false-positive trigger from prohibited-process detection.
Reformat/update README content to reflect packaging and improve readability.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.

File	Description
`src/security/security_service.cpp`	Adjust prohibited-process list to reduce false positives.
`scripts/build-release.sh`	Switch release packaging to AppImage (currently with major workflow/safety issues).
`README.md`	Formatting + wording updates to reflect AppImage distribution and build instructions.
`.github/workflows/release.yml`	Publish `dist/*.AppImage` artifacts in CI and GitHub releases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tectrixdev · 2026-04-28T06:55:04Z

Notable copilot answers:

Verify hash of the linux build appimages
~~Static paths~~
Refer to my comment replies

tectrixdev · 2026-04-28T07:14:08Z

I'll push some fixes later today.

again as the environment vairable didn't work.

tectrixdev · 2026-05-01T11:55:08Z

Finally got past the linuxdeploy on the runner.

tectrixdev · 2026-05-01T11:55:22Z

We'll see if the ouput build works better.

tectrixdev · 2026-05-01T12:01:56Z

Got a build, but for some reason it's still outputting this weird qtwebengine debugging. I don't know what causes that and if that might cause problems (bottom is my build top is github.) I've packaged as much of the dependencies my build has as possible. Still missing some, they are in the comments on line 12-15 in the build script.

tectrixdev · 2026-05-01T12:14:23Z

Allright, so I installed the built AppImage on my system using gear lever, unplugged my monitors, ... and opened the test from the teacher. It now works! I had to apply some restrictions manually using kde window rules as it doesn't automatically enable anti cheat but it fully works now.

tectrixdev · 2026-05-01T12:15:05Z

I'll finalize the PR now.

tectrixdev · 2026-05-01T12:25:30Z

Should be ready to merge, changes:

fixed anticheat false-positive
added AppImage builds
fixed v3 sebs:// not opening
fixed some markdown formatting

chatgpt-codex-connector · 2026-05-01T12:25:35Z

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

tectrixdev · 2026-05-01T12:28:33Z

Changes for future PRs:

add a "download as an AppImage" button to README.md
mention using gearlever to install
maybe add AppImages to https://appimage.github.io/apps/

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

 constexpr int kSebRncryptorKeyLength = 32;
 constexpr int kSebRncryptorIterations = 10000;
-constexpr int kSebRncryptorVersion = 0x2;
+constexpr int kSebRncryptorVersion = 0x3;


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

tectrixdev · 2026-05-01T14:55:59Z

Allright, thanks for helping making the final touches, the reason I've changed the pull request template was purely to resolve markdown standard issues, see: https://rumdl.dev/. But that's completely optional, and these are just guidelines.

Copilot

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+unset QMAKE
+unset EXTRA_QT_MODULES
+export QML_SOURCES_PATHS="$PROJECT_DIR"/src
+export QMAKE=$(which qmake6)


+
+if command -v apt >/dev/null; then
+    echo "installing dependencies"
+    sudo apt-get update
+    sudo apt-get install -y \


+    const QByteArray computedHmac = QMessageAuthenticationCode::hash(
+        data.left(data.size() - hmacLength), authenticationKey,
+        QCryptographicHash::Sha256);
+
+    if (computedHmac == originalHmac) {
+      encryptionKey = deriveKey(passwordBytes, encryptionSalt);
+      authenticated = true;
+      break;
+    }


+    if ! wget -q "${url}" -O "${tmp_path}"; then
+        rm -f "${tmp_path}"
+        echo "Failed to download ${url}" >&2


+}
+
+echo "Installing dependencies"
+${ROOT_DIR}/scripts/dependencies.sh


Jvr2022 · 2026-05-01T15:25:09Z

LGTM!

tectrixdev added 7 commits April 27, 2026 21:57

Remove gdbus check to avoid issues with genuine system configurations.

825a052

(For example, plasma panel colorizer needs gdbus running for some reason).

Add AppImage builds.

cb8fb36

Fix markdown formatting in the readme and update it for the AppImage

3c7a215

builds.

Don't remove makefile.

e6ab773

Fix building issues (spelling error).

034606e

qake6 --> qmake5

2b589a5

Add debugging + fix some oversights.

2933534

No need for re-exporting ENV var.

a802cd3

tectrixdev added 2 commits April 27, 2026 23:06

Temporarily disable webkit builds.

55f0609

Skip debian build too.

7317efa

Jvr2022 requested a review from Copilot April 28, 2026 05:16

Copilot started reviewing on behalf of Jvr2022 April 28, 2026 05:16 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

tectrixdev added 2 commits April 28, 2026 08:51

Fix readme consistency.

ba62405

Capitalization.

4e1d39f

tectrixdev added 6 commits April 28, 2026 12:20

some minor changes and fixes

e8086aa

Change directory, output AppImage.

81d4b9e

Small fixes.

57da327

Another small fix.

5e06a7a

Fix wrong flag.

d40c3f1

Add some more dependencies to the workflow file, hardcode the build name

c8ed620

again as the environment vairable didn't work.

tectrixdev added 3 commits May 1, 2026 13:44

Add debian package.

e65f6c9

Remove yet another dependency.

9332692

Remove libxml2.

dbe1042

tectrixdev added 2 commits May 1, 2026 14:18

Restore gitignore.

5cd5dee

Fix github markdown formatting.

a2ffc07

tectrixdev marked this pull request as ready for review May 1, 2026 12:25

Jvr2022 requested a review from Copilot May 1, 2026 12:36

Copilot started reviewing on behalf of Jvr2022 May 1, 2026 12:36 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Jvr2022 and others added 4 commits May 1, 2026 16:23

Remove apt-get ignore-missing flag to fail fast on missing dependencies

8b62850

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Restore the pull request template to its previous version

b5c874e

Remove the note from the readme

5dbabf2

build(scripts): keep build.sh dependency-free

60f3cd8

Jvr2022 added 2 commits May 1, 2026 17:05

build(release): pin AppImage tooling and isolate release builds

95a7c6e

feat(seb-files) Add support for v2 files

2773933

Jvr2022 requested a review from Copilot May 1, 2026 15:19

Copilot started reviewing on behalf of Jvr2022 May 1, 2026 15:19 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Jvr2022 changed the title ~~Draft: AppImage builds + fix false-positive in the anti-cheat + fix opening encrypted files.~~ AppImage builds + fix false-positive in the anti-cheat + fix opening encrypted files. May 1, 2026

Jvr2022 merged commit fd4ca80 into Jvr2022:main May 1, 2026
8 checks passed

Conversation

tectrixdev commented Apr 27, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What Changed

Draft

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

tectrixdev commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tectrixdev commented Apr 27, 2026

Uh oh!

tectrixdev commented Apr 27, 2026

Uh oh!

tectrixdev commented Apr 27, 2026

Uh oh!

tectrixdev commented Apr 27, 2026

Uh oh!

tectrixdev commented Apr 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tectrixdev commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tectrixdev commented Apr 28, 2026

Uh oh!

tectrixdev commented May 1, 2026

Uh oh!

tectrixdev commented May 1, 2026

Uh oh!

tectrixdev commented May 1, 2026

Uh oh!

tectrixdev commented May 1, 2026

Uh oh!

tectrixdev commented May 1, 2026

Uh oh!

tectrixdev commented May 1, 2026

Uh oh!

chatgpt-codex-connector Bot commented May 1, 2026

Uh oh!

tectrixdev commented May 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tectrixdev commented May 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

tectrixdev commented Apr 27, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 27, 2026 •

edited

Loading

tectrixdev commented Apr 27, 2026 •

edited

Loading

tectrixdev commented Apr 28, 2026 •

edited

Loading