fix(cgi): timeout 5s — kills frozen script, returns 504#20
Merged
Conversation
- Replace blocking read() with select()-based readOutputWithTimeout() - Kill child process with SIGKILL on timeout, return 504 Gateway Timeout - Add infinite.py test script and timeout unit test (14/14) - Add demo_cgi.cpp for manual shell testing Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Un script CGI qui tourne indéfiniment bloquait le
read()du parent → le serveur freezait sur cette connexion.Fix
Remplace le
read()bloquant parselect()avec un timeout de 5 secondes :kill(pid, SIGKILL)+waitpid+ 504 Gateway TimeoutTests
www/cgi-bin/infinite.py(sleep 30s) → 504 en 5s confirméMade with Cursor