Skip to content

fix(cpp98): vector::data() → &v[0], pipe fd leak, buildAutoindex 403 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byronlove111 merged 1 commit into from
Jun 17, 2026
Merged

fix(cpp98): vector::data() → &v[0], pipe fd leak, buildAutoindex 403 #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/http/cgi/execute.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,14 @@ HttpResponse CgiHandler::execute(const HttpRequest& request, const LocationConfi

int stdinPipe[2];
int stdoutPipe[2];
if (pipe(stdinPipe) == -1 || pipe(stdoutPipe) == -1)
if (pipe(stdinPipe) == -1)
return buildHttpError(500, "Internal Server Error");
if (pipe(stdoutPipe) == -1)
{
close(stdinPipe[0]);
close(stdinPipe[1]);
return buildHttpError(500, "Internal Server Error");
}

pid_t childPid = fork();
if (childPid == -1)
Expand All @@ -118,7 +124,7 @@ HttpResponse CgiHandler::execute(const HttpRequest& request, const LocationConfi
}

if (childPid == 0)
runChildProcess(interpreter, scriptPath, argv, envPointers.data(), stdinPipe, stdoutPipe);
runChildProcess(interpreter, scriptPath, argv, &envPointers[0], stdinPipe, stdoutPipe);

close(stdinPipe[0]);
close(stdoutPipe[1]);
Expand Down
7 changes: 1 addition & 6 deletions src/http/handlers/GetHandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,7 @@ static HttpResponse buildAutoindex(const std::string& directoryPath, const std::
{
DIR* directory = opendir(directoryPath.c_str());
if (!directory)
{
HttpResponse response;
response.status_code = 403;
response.status_msg = "Forbidden";
return response;
}
return buildHttpError(403, "Forbidden");

std::string listingHtml = "<html><body><h1>Index of " + requestUri + "</h1><ul>";

Expand Down
Loading