feat: add kvstore-manager to collect kvstore metrics#35
Open
feat: add kvstore-manager to collect kvstore metrics#35
Conversation
K-Yo
requested changes
Apr 7, 2026
| } | ||
|
|
||
| ret := true | ||
| server := "local" // Default server identifier |
Owner
There was a problem hiding this comment.
ça le fixe pour toutes les métriques, non? ça serait pas mieux de le récupérer depuis le champ url dans la conf? ou sinon màj la doc pour prévenir que ça sera toujours "local"
Comment on lines
+199
to
+205
| type mockCollector struct { | ||
| metrics []prometheus.Metric | ||
| } | ||
|
|
||
| func (m *mockCollector) Collect(metric prometheus.Metric) { | ||
| m.metrics = append(m.metrics, metric) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.