Apply mechanical fixes from repo review#15
Merged
Conversation
- Fix /Volumess typo so /Volumes is actually unhidden - Drop http:// insteadOf rewrite that downgraded ssh remotes to plain http - Add set -euo pipefail to all chezmoi scripts so failures surface in CI (guard $CI expansion and tolerate killall when Safari isn't running) - Add ripgrep and fd, required by the Neovim telescope config Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low-risk fixes surfaced during a holistic review of the repo:
/Volumesstypo in the macOS defaults script — thechflags nohiddenfor/Volumeshas been silently failing on every setup.http://github.com/insteadOf rewrite in.gitconfig— it rewrotessh://remotes to plain unencrypted http and defeated the work/personal SSH-key split. Thegit://→https://rewrite is kept.set -euo pipefailto all.chezmoiscriptsso a failing step actually fails the apply (and CI). Required guarding$CIwith${CI:-}and toleratingkillall Safariwhen Safari isn't running.ripgrepandfdto packages — the Neovim telescope config depends onrgforlive_grep, andfdspeeds upfind_files.Verified with
bash -non all scripts andchezmoi execute-templateon the packages template; CI's greenfield apply will exercise the scripts for real.🤖 Generated with Claude Code