Merged
Conversation
Contributor
iamsergio
commented
Feb 25, 2025
iamsergio
commented
- Fix last Qt6 blocker which was preventing tests from passing
- Add CI Coverage for Qt6, macOS and Windows
Qt6 port is now complete, as its tests all pass with this fix. Don't emit signals in an extension after its target widget dtors have already started. QQmlProxyMetaObject doesn't like its parents meta-objects offsets changing.
Qt6 gets build coverage on all platforms, plus test coverage on Linux. macOS and Windows tests to be investigated, as they currently crash. Separated the Qt5 yml file from the Qt6 one, as typically the Qt6 one will evolve and the Qt5 one will stay the same. Doing everything in one file will require the number of "ifs" and special cases. Qt5 for example doesn't build on ARM macs unless we rework the Qt installation steps. Since Qt5 is EOL let's not have it get in the way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.