Feat/conquer hardening#258
Merged
Merged
Conversation
…arity Two review follow-ups from the conquer falsifier round: (1) unattended --push now refuses to land on a protected branch (main/master by default, protectedPushBranches config override, case-insensitive, fail-closed on an unresolvable HEAD) via isProtectedPushBranch in the forge decision core — a conquer worktree normally sits on its own conquer/<slug> branch, so a protected HEAD means something unexpected happened and the work stays committed locally for a human push. (2) the REPL /conquer handler no longer hardcodes what the CLI exposes: --gate-timeout, --max-hours and --timeout parse through the intent layer and reach the gate spawn and runConquer caps, mirroring the CLI defaults (1800s gate, 600s turn, no wall cap). ⚔️ Forged by [Agon](https://github.com/KERNlang/agon) Co-Authored-By: agon (KERN) <292465531+KERN-Agon@users.noreply.github.com>
Full-roster review (6/6 engines, 5-engine consensus on the blocker):
KERN codegen emits optional array fields as [] into DEFAULT_AGON_CONFIG,
so every real loadConfig() caller passed { protectedPushBranches: [] } and
the Array.isArray fallback never fired — main/master were NOT protected in
production. An empty or whitespace-only list now falls back to the default
['main','master']; only a non-empty override replaces it. Verified against
the real loadConfig() output. Also: CLI --timeout/--gate-timeout reject
negative values instead of propagating them to spawnWithTimeout (agy), the
REPL /conquer rejects --max-turns < 1 exactly like the CLI (minimax), and
the exact production config state is now a test case (zai).
Refuted (no change): the cqAbort cleanup claim — the handler's KERN
cleanup block generates the finally { ctx.setActiveAbort(null) }, and a
still-running background job after /focus-away is the job system's design.
⚔️ Forged by [Agon](https://github.com/KERNlang/agon)
Co-Authored-By: agon (KERN) <292465531+KERN-Agon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.