Skip to content

Wrap raw TypeError/RuntimeError in GMDCommandError #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karstenm1987 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Wrap raw TypeError/RuntimeError in GMDCommandError #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions global_macro_data/gmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ def _tokens(value: Union[str, Sequence[str], None]) -> List[str]:
if isinstance(value, str):
bits = value.replace(",", " ").split()
return [bit.strip() for bit in bits if bit.strip()]
if not isinstance(value, (list, tuple)):
raise GMDCommandError(
f"Expected a string or sequence of strings, got {type(value).__name__}.",
code=198,
)
out: List[str] = []
for item in value:
if isinstance(item, str):
Expand Down Expand Up @@ -330,13 +335,16 @@ def _strip_source_prefix_cols(df: pd.DataFrame, source: str) -> List[str]:
def get_available_versions() -> List[str]:
try:
return _versions_df()["versions"].astype(str).tolist()
except RuntimeError:
except RuntimeError as exc:
versions = _cache_versions()
if versions:
return versions
if _default_local_gmd_path() is not None:
return ["local"]
raise
raise GMDCommandError(
"Unable to fetch the list of available GMD versions. "
"Check your internet connection or raise an issue."
) from exc


def get_current_version() -> str:
Expand Down