Potential implementation of mesh warning system#219
Closed
keiyamamo wants to merge 2 commits intoKVSlab:masterfrom
Closed
Potential implementation of mesh warning system#219keiyamamo wants to merge 2 commits intoKVSlab:masterfrom
keiyamamo wants to merge 2 commits intoKVSlab:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
=======================================
Coverage 82.00% 82.01%
=======================================
Files 32 32
Lines 4013 4014 +1
=======================================
+ Hits 3291 3292 +1
Misses 722 722 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
I think printing out this mesh statistics would be enough for now. We can potentially implement mesh warning system as future update. |
Collaborator
|
@keiyamamo - please see PR #222. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @johannesring @jorgensd
This is not a PR (yet) but I would like to discuss how we should implement warning system in the meshing pipeline.
By setting the
tetgen.Verbose = 1, I know we could get the following information (printed in the terminal). This could potentially be used to detect “low-quality” mesh, but we would need some threshold for that. Do you have suggestions for what metrics and what threshold should be used?Additionally, I could not figure out how to obtain printed information as python objects. I used
sys.stdoutbut that did not work. It might be because those information come fromtetgenthroughVMTK. If you have some idea how to do that, I would appreciate it.