feat(mysql): implement columnStats using INFORMATION_SCHEMA.STATISTICS#233
Open
samuelayanshina wants to merge 1 commit into
Open
feat(mysql): implement columnStats using INFORMATION_SCHEMA.STATISTICS#233samuelayanshina wants to merge 1 commit into
samuelayanshina wants to merge 1 commit into
Conversation
|
@samuelayanshina is attempting to deploy a commit to the Kaelio Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thanks for the contribution @samuelayanshina - reviewing this and will get back to you soon |
Enable column cardinality statistics for the MySQL connector by querying INFORMATION_SCHEMA.STATISTICS, which provides index-based cardinality estimates without requiring additional permissions. - Add generateColumnStatisticsQuery() to KtxMysqlDialect - Add getColumnStatistics() and columnStats() to KtxMysqlScanConnector - Flip columnStats capability from false to true - Add MysqlStatsRow and KtxMysqlColumnStatisticsResult interfaces - Add tests for dialect query generation and connector stats retrieval - Update dialect conformance fixture for mysql
afb4a18 to
2acd711
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MySQL connector had columnStats disabled generateColumnStatisticsQuery returned null and the capability was set to false. This PR implements column cardinality statistics for MySQL, bringing it to parity with the Postgres connector.
What changed:
Why INFORMATION_SCHEMA.STATISTICS:
MySQL doesn't expose a pg_stats equivalent for all columns. INFORMATION_SCHEMA.STATISTICS provides reliable cardinality estimates for indexed columns without requiring extra permissions or prior ANALYZE TABLE calls, making it the most practical approach for MySQL 5.7+.