Integrate ignore_patterns into Models upload#1126
Closed
stevemessick wants to merge 5 commits into
Closed
Conversation
- Define DEFAULT_IGNORE_PATTERNS. - Implement should_ignore helper. - Update DirectoryArchive to support filtering for zip/tar formats. - Add unit tests for should_ignore and DirectoryArchive. TAG=agy CONV=2a820637-152b-46a6-9a45-e29918f1e322
TAG=agy CONV=2a820637-152b-46a6-9a45-e29918f1e322
- Update KaggleApi.upload_files to accept ignore_patterns. - Update model_instance_create and model_instance_version_create to accept and pass ignore_patterns. - Add --ignore-patterns CLI argument to model creation commands. - Add unit tests for model creation with ignore_patterns. TAG=agy CONV=2a820637-152b-46a6-9a45-e29918f1e322
TAG=agy CONV=2a820637-152b-46a6-9a45-e29918f1e322
TAG=agy CONV=2a820637-152b-46a6-9a45-e29918f1e322
stevemessick
force-pushed
the
feature/ignore-patterns-models
branch
from
July 16, 2026 20:36
1cff7fa to
6053df0
Compare
Contributor
Author
|
Closing; see #1130. |
stevemessick
added a commit
that referenced
this pull request
Jul 16, 2026
This PR combines all the work for implementing `ignore_patterns` in model, dataset, and competition uploading, along with documentation. It contains changes from the following PRs (kept open for reference): - #1125 (Core logic) - #1126 (Models integration) - #1127 (Datasets integration) - #1128 (Competitions integration) - #1129 (Documentation) Key Changes: - Core: Define `DEFAULT_IGNORE_PATTERNS` and `should_ignore()`. Update `DirectoryArchive` to filter files/dirs. - Models: Integrate `ignore_patterns` into model uploading API and CLI (`--ignore-patterns`). - Datasets: Integrate `ignore_patterns` into dataset uploading API and CLI (`--ignore-patterns`). - Competitions: Integrate `ignore_patterns` into competition data update walk. Bypass defaults if `include_hidden` is True. Add CLI support. - Docs: Document the new option for all commands. TAG=agy CONV=2a820637-152b-46a6-9a45-e29918f1e322
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates
ignore_patternsinto the models upload workflow.Changes:
KaggleApi.upload_filesto acceptignore_patterns.model_instance_createandmodel_instance_version_create(and CLI wrappers) to accept and passignore_patterns.--ignore-patternsCLI argument to model creation commands.Depends on #1125 (core logic).
TAG=agy
CONV=2a820637-152b-46a6-9a45-e29918f1e322