sesison logout #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlee-kalshi
reviewed
Jan 26, 2026
| func (s *SessionSuite) TestOnAdminStop() { | ||
| s.session.State = logonState{} | ||
|
|
||
| s.session.onAdmin(stopReq{}) |
mlee-kalshi
reviewed
Jan 26, 2026
| } | ||
|
|
||
| // StopSession logs out a specific session, closes its connection, and stops it. | ||
| func (a *Acceptor) StopSession(sessionID SessionID) error { |
There was a problem hiding this comment.
do you not need to call UnregisterSession?
neilnachnani
force-pushed
the
add-session-logout
branch
from
c156f3e to
c3d54a2
Compare
address PR review: add UnregisterSession call, fix indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.