ci: full-suite gate on Python 3.11 with authenticated mongo service a…#923
Open
ilayfalach wants to merge 3 commits into
Open
ci: full-suite gate on Python 3.11 with authenticated mongo service a…#923ilayfalach wants to merge 3 commits into
ilayfalach wants to merge 3 commits into
Conversation
…nd injected pyhera config Replaces the prior 3.12-based gate (commit 82ced32) with a Python 3.11 target per Lior's rollout direction. Mongo service runs mongo:latest with MONGO_INITDB_ROOT_USERNAME/PASSWORD = hera/heracles; healthcheck uses authenticated mongosh ping. Step "Write ~/.pyhera/config.json" injects the matching config before pytest so hera's import-time DB connect succeeds. Internal deps hermes and argos are vendored via actions/checkout into _vendor/ and installed with pip install -e. Pytest invocation: pytest hera/tests/ -v -m "not notebook" — the dead "openfoam" filter and decorative MONGO_HOST/MONGO_PORT env vars are removed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ksql==0.10.2 has been pinned in requirements.txt but is not imported anywhere in hera/. Its setup.py does `import pip` inside an isolated build env, which fails on modern pip (26.x) with `ModuleNotFoundError: No module named 'pip'`. Locally it survives only because pre-existing virtualenvs were built with an older pip; fresh CI runners always fail at this line. No consumers in the codebase, no transitive justification — removing. Surfaced by the first run of .github/workflows/ci.yml on issue884-v2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sphinx-basic-ng has no stable 1.0.0 release on PyPI — only pre-releases up to 1.0.0b2 exist. Under PEP 440, `>=1.0.0` excludes pre-releases, so pip 26 fails resolution with "No matching distribution found". Pin to the latest available beta (==1.0.0b2) to match the rest of requirements.txt's `==` convention. This is a docs-time transitive (via furo) — not exercised by the test suite. Surfaced by the second run of .github/workflows/ci.yml on issue884-v2. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd injected pyhera config
Replaces the prior 3.12-based gate (commit 82ced32) with a Python 3.11 target per Lior's rollout direction. Mongo service runs mongo:latest with MONGO_INITDB_ROOT_USERNAME/PASSWORD = hera/heracles; healthcheck uses authenticated mongosh ping. Step "Write ~/.pyhera/config.json" injects the matching config before pytest so hera's import-time DB connect succeeds. Internal deps hermes and argos are vendored via actions/checkout into _vendor/ and installed with pip install -e. Pytest invocation: pytest hera/tests/ -v -m "not notebook" — the dead "openfoam" filter and decorative MONGO_HOST/MONGO_PORT env vars are removed.