fix(create-termui-app): validate project name to prevent path traversal#710
Open
Siddh2024 wants to merge 1 commit into
Open
fix(create-termui-app): validate project name to prevent path traversal#710Siddh2024 wants to merge 1 commit into
Siddh2024 wants to merge 1 commit into
Conversation
Karanjot786
added
gssoc:approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The \create-termui-app\ scaffolding tool accepts arbitrary project names from user input (CLI args or interactive prompt) and passes them directly to
esolve()\ and \join()\ for file system operations without any validation. This allows path traversal via names like ../../../etc/evil\ or ../../malicious, enabling arbitrary file writes outside the intended project directory.
Root Cause
At \index.ts:92\ and \index.ts:147:
\\ s
const projectDir = resolve(process.cwd(), projectName);
\\
\projectName\ comes from \�rgs.name\ (CLI argument) or \ extPrompt()\ (interactive) — both unsanitized.
The Fix
Added \�alidateProjectName()\ that checks the name against /^[a-zA-Z0-9@][a-zA-Z0-9_.-]*$/\ and rejects ./... Called after name resolution from both CLI args and the interactive prompt.
Closes #705